Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Enable listing at project level 2/n #16622

Merged
merged 94 commits into from
Feb 3, 2023
Merged

[App] Enable listing at project level 2/n #16622

merged 94 commits into from
Feb 3, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 3, 2023 •
edited by github-actions bot

What does this PR do?

This PR enable listing through an entire project and rely on the optimised API.

Currently working only on staging. Needs to wait for next platform release.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

thomas and others added 30 commits February 1, 2023 11:33
update
984421c
update
25bf9f6
Merge branch 'master' of https://github.com/Lightning-AI/lightning in…
258c9ec 
…to storage_commands
update
5ca87d0
update
24b86d1
update
7fe89be
update
cc1bcb7
update
2c70775
update
34c7796
update
00e47c1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7ec12c6 
for more information, see https://pre-commit.ci
@tchaton
Merge branch 'master' into storage_commands
e3d5e60
update
29c1789
update
914b59a
update
af67e93
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
16b6069 
for more information, see https://pre-commit.ci
update
22ca6d2
update
22380a7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
752744b 
for more information, see https://pre-commit.ci
update
b053e27
Merge branch 'storage_commands' of https://github.com/Lightning-AI/li…
a7c8199 
…ghtning into storage_commands
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f45eb1a 
for more information, see https://pre-commit.ci
update
079fb7e
update
7c05441
Merge branch 'storage_commands' of https://github.com/Lightning-AI/li…
3941b0c 
…ghtning into storage_commands
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
27d33b0 
for more information, see https://pre-commit.ci
update
701f153
update
8d88889
update
f7700c7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
51ddaa9 
for more information, see https://pre-commit.ci
@tchaton tchaton changed the title [App] Enable listing at project level [App] Enable listing at project level 2/n Feb 3, 2023
@tchaton tchaton marked this pull request as draft February 3, 2023 13:02
@tchaton tchaton marked this pull request as ready for review February 3, 2023 13:46
@tchaton tchaton added this to the future milestone Feb 3, 2023
ethanwharris
ethanwharris approved these changes Feb 3, 2023
View reviewed changes
src/lightning/app/CHANGELOG.md Outdated Show resolved Hide resolved
src/lightning/app/cli/commands/ls.py Show resolved Hide resolved
@tchaton @ethanwharris
Update src/lightning/app/CHANGELOG.md
bd4f6bc 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
@tchaton tchaton enabled auto-merge (squash) February 3, 2023 14:52
@tchaton tchaton merged commit 03bb29c into master Feb 3, 2023
@tchaton tchaton deleted the storage_commands_optimised branch February 3, 2023 14:57
@mergify mergify bot added the ready PRs ready to be merged label Feb 3, 2023
akihironitta
akihironitta approved these changes Feb 3, 2023
View reviewed changes
src/lightning/app/CHANGELOG.md Show resolved Hide resolved
@carmocca carmocca modified the milestones: future, v1.9.x Feb 6, 2023
Borda pushed a commit that referenced this pull request Feb 9, 2023
@tchaton @Borda
[App] Enable listing at project level 2/n (#16622)
182010c 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
Borda pushed a commit that referenced this pull request Feb 9, 2023
@tchaton @Borda
[App] Enable listing at project level 2/n (#16622)
3db9a20 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
Borda pushed a commit that referenced this pull request Feb 9, 2023
@tchaton @Borda
[App] Enable listing at project level 2/n (#16622)
1da6dfc 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
Borda pushed a commit that referenced this pull request Feb 9, 2023
@tchaton @Borda
[App] Enable listing at project level 2/n (#16622)
9f00065 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
Borda pushed a commit that referenced this pull request Feb 9, 2023
@tchaton @Borda
[App] Enable listing at project level 2/n (#16622)
989322d 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
lantiga pushed a commit that referenced this pull request Feb 10, 2023
@tchaton @lantiga
[App] Enable listing at project level 2/n (#16622)
b50c8c8 
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
Co-authored-by: thomas <thomas@thomass-MacBook-Pro.local>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 03bb29c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@akihironitta akihironitta akihironitta approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

Assignees

@tchaton tchaton

Labels
app:cli app Generic label for Lightning App package ready PRs ready to be merged
Projects
No open projects
Lightning App Ecosystem
Status: Done
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tchaton @Borda @ethanwharris @akihironitta @carmocca