Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Resolve bug with download #16626

Closed
wants to merge 8 commits into from
Closed

[App] Resolve bug with download #16626

wants to merge 8 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 3, 2023

What does this PR do?

This resolves a bug discovered while running the demo. The path of the objects was trailing and concatenation with destination path didn't work as expected.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added app Generic label for Lightning App package app:cli labels Feb 3, 2023
@tchaton tchaton added this to the future milestone Feb 3, 2023
@tchaton tchaton self-assigned this Feb 3, 2023
@tchaton tchaton added the bug Something isn't working label Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the has conflicts label Feb 5, 2023
tchaton and others added 2 commits February 7, 2023 16:02
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@github-actions github-actions bot removed the app Generic label for Lightning App package label Feb 7, 2023
@mergify mergify bot removed the has conflicts label Feb 7, 2023
@awaelchli
Copy link
Member

The diff in this PR is empty

@tchaton tchaton closed this Feb 7, 2023
@tchaton tchaton deleted the resolve_cp_bug branch February 7, 2023 16:32
@carmocca carmocca modified the milestones: future, v1.9.x Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:cli bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants