Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for neptune 1.0 #16761

Merged
merged 36 commits into from
Mar 21, 2023
Merged

update for neptune 1.0 #16761

merged 36 commits into from
Mar 21, 2023

Conversation

kshitij12345
Copy link
Contributor

@kshitij12345 kshitij12345 commented Feb 15, 2023 •
edited

What does this PR do?

Updates to NeptuneLogger aligned with Neptune 1.0 release.
Ref: https://docs.neptune.ai/setup/neptune-client_1-0_release_changes/

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 15, 2023
@kshitij12345 kshitij12345 changed the title update for neptune 1.0 [WIP] update for neptune 1.0 Feb 15, 2023
@twolodzko
Copy link

You missed one .log in log_metrics line 424

@twolodzko
Copy link

  • In the docstrings, you have the deprecated "ANONYMOUS" instead of neptune.ANONYMOUS_API_TOKEN.
  • I might have missed it, but it'd be good to have unit tests on using the handlers instead of Run.

@Borda Borda mentioned this pull request Feb 28, 2023
Merged
7 tasks
@kshitij12345
Copy link
Contributor Author

@twolodzko

In the docstrings, you have the deprecated "ANONYMOUS" instead of neptune.ANONYMOUS_API_TOKEN.

Updated!

I might have missed it, but it'd be good to have unit tests on using the handlers instead of Run.

I am not sure if we can easily mock the handlers. Though I have tested locally and made a few changes as wait and exists method are not supported on Handler.

PTAL :)

@Blaizzy Blaizzy mentioned this pull request Mar 1, 2023
Closed
@mergify mergify bot added the ready PRs ready to be merged label Mar 20, 2023
@kshitij12345
Copy link
Contributor Author

@Borda there are another couple of failing tests. Will fix them.

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Mar 20, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 20, 2023
@kshitij12345
Copy link
Contributor Author

kshitij12345 commented Mar 21, 2023 •
edited

@Borda @carmocca two CI failures look irrelevant (timeouts).

@awaelchli awaelchli requested a review from carmocca March 21, 2023 11:07
@carmocca carmocca enabled auto-merge (squash) March 21, 2023 14:53
@carmocca carmocca merged commit 04a2f33 into Lightning-AI:master Mar 21, 2023
@awaelchli awaelchli mentioned this pull request Mar 26, 2023
Closed
Borda pushed a commit that referenced this pull request Mar 31, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
b8605c0 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Borda pushed a commit that referenced this pull request Mar 31, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
bc4f499 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Borda pushed a commit that referenced this pull request Mar 31, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
8df03c3 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
lantiga pushed a commit that referenced this pull request Apr 3, 2023
@kshitij12345 @lantiga
update for neptune 1.0 (#16761)
253ee12 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Borda pushed a commit that referenced this pull request Jun 9, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
d10aac0 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Borda pushed a commit that referenced this pull request Jun 9, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
32dbf6e 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Borda pushed a commit that referenced this pull request Jun 13, 2023
@kshitij12345 @Borda
update for neptune 1.0 (#16761)
95bcd46 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
lantiga pushed a commit that referenced this pull request Jun 22, 2023
@kshitij12345 @lantiga
update for neptune 1.0 (#16761)
abcad9a 
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

(cherry picked from commit 04a2f33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twolodzko twolodzko twolodzko approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@normandy7 normandy7 normandy7 approved these changes

@carmocca carmocca carmocca approved these changes

@Blaizzy Blaizzy Blaizzy approved these changes

@AleksanderWWW AleksanderWWW AleksanderWWW approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
community This PR is from the community logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kshitij12345 @twolodzko @awaelchli @Borda @normandy7 @carmocca @Blaizzy @AleksanderWWW