Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Refactor plugins to be a standalone LightningPlugin #16765

Merged
merged 36 commits into from
Feb 17, 2023

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Feb 15, 2023

What does this PR do?

Changes plugins to be standalone, similar to apps - rather than children of apps.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli

@github-actions github-actions bot added the app Generic label for Lightning App package label Feb 15, 2023
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

src/lightning/app/core/flow.py Show resolved Hide resolved
src/lightning/app/core/plugin.py Show resolved Hide resolved
src/lightning/app/core/plugin.py Show resolved Hide resolved
src/lightning/app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning/app/utilities/load_app.py Show resolved Hide resolved
@ethanwharris ethanwharris changed the title [WIP] Refactor plugins to be a standalone LightningPlugin Refactor plugins to be a standalone LightningPlugin Feb 15, 2023
@ethanwharris ethanwharris marked this pull request as ready for review February 15, 2023 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) success
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py, tests/tests_app/cli/test_run_app.py, tests/tests_app/core/lightning_app/test_configure_layout.py, tests/tests_app/core/test_plugin.py, tests/tests_app/runners/test_cloud.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (lightning) success
make-html (lightning) success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/app/__init__.py, src/lightning/app/core/__init__.py, src/lightning/app/core/flow.py, src/lightning/app/core/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/runners/multiprocess.py, src/lightning/app/utilities/commands/base.py, src/lightning/app/utilities/load_app.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@ethanwharris ethanwharris changed the title Refactor plugins to be a standalone LightningPlugin [App] Refactor plugins to be a standalone LightningPlugin Feb 15, 2023
src/lightning/__init__.py Outdated Show resolved Hide resolved
src/lightning/app/core/plugin.py Show resolved Hide resolved
src/lightning/app/runners/cloud.py Outdated Show resolved Hide resolved
src/lightning/app/runners/cloud.py Show resolved Hide resolved
src/lightning/app/runners/cloud.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Feb 16, 2023
@awaelchli awaelchli added this to the v1.9.x milestone Feb 16, 2023
@awaelchli
Copy link
Member

@ethanwharris Since this will probably merge soon, could I ask you to then cherry-pick that commit over into this branch: #16790 for an efficient releasing in the coming days. Thanks in advance!

@ethanwharris ethanwharris merged commit 7f92d5c into master Feb 17, 2023
@ethanwharris ethanwharris deleted the feature/plugins_part_2 branch February 17, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Generic label for Lightning App package ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants