New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Add `healthz` endpoint to plugin server #16882

Merged

ethanwharris merged 8 commits into master from feature/plugin_server_healthz

Mar 3, 2023

Member

ethanwharris commented Feb 27, 2023 •

edited by github-actions bot

What does this PR do?

Adds a health endpoint so the BE knows when the server is ready.

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

ethanwharris added 2 commits

February 24, 2023 14:52


          Add health endpoint to plugin server

a4f2e87


          Add small test

28a0a3c

ethanwharris requested review from tchaton, lantiga, awaelchli and hhsecond as code owners

February 27, 2023 11:28

github-actions bot added the app label

Contributor

github-actions bot commented Feb 27, 2023 •

edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, tests/tests_app/plugin/test_plugin.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

awaelchli approved these changes

View reviewed changes

awaelchli added the feature label

awaelchli added this to the v1.9.x milestone

ethanwharris self-assigned this


          Merge branch 'master' into feature/plugin_server_healthz

6146c60

Borda approved these changes

View reviewed changes

src/lightning/app/plugin/plugin.py Outdated Show resolved Hide resolved

mergify bot added the ready label

Borda and others added 3 commits

March 1, 2023 17:15


          Merge branch 'master' into feature/plugin_server_healthz

fb6a168


          Merge branch 'master' into feature/plugin_server_healthz

22887ad


          Typing

5c74488

ethanwharris enabled auto-merge (squash)

March 2, 2023 22:35


          Merge branch 'master' into feature/plugin_server_healthz

af9bc06

ethanwharris disabled auto-merge

March 3, 2023 07:43


          Merge branch 'master' into feature/plugin_server_healthz

3a3faa9

ethanwharris merged commit ba2c378 into master

ethanwharris deleted the feature/plugin_server_healthz branch

March 3, 2023 09:47

nohalon pushed a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

ad435a6

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Borda added a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

3905c46

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Borda added a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

88f8e66

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Borda added a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

659b4ed

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Borda added a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

0f7b8dc

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

Borda pushed a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

e272c94

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit ba2c378)

lantiga pushed a commit that referenced this pull request


          [App] Add healthz endpoint to plugin server (#16882)

3e93382

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit ba2c378)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

awaelchli awaelchli approved these changes

Borda Borda approved these changes

tchaton Awaiting requested review from tchaton tchaton is a code owner

lantiga Awaiting requested review from lantiga lantiga is a code owner

hhsecond Awaiting requested review from hhsecond