[App] Content for plugins #17243

ethanwharris · 2023-03-31T10:37:35Z

What does this PR do?

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

for more information, see https://pre-commit.ci

…AI/lightning into feature/plugins_mount_content

for more information, see https://pre-commit.ci

…AI/lightning into feature/plugins_mount_content

stale · 2023-04-14T20:23:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

github-actions · 2023-05-21T13:02:14Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, tests/tests_app/runners/test_cloud.py, tests/tests_app/source_code/test_local.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning/app/runners/cloud.py

…ghtning-AI/lightning into feature/plugins_mount_content

tchaton

Love it !

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> (cherry picked from commit 2c3dfc0)

ethanwharris added 8 commits March 14, 2023 14:22

Initial commit

fb225dc

Fix

fc66587

No hash

155f732

Logging

c53b73d

Move to /home/zeus

e3106e5

Fix

f8a0e6a

Updates

19137c9

Revert

842420f

github-actions bot added the app Generic label for Lightning App package label Mar 31, 2023

ethanwharris and others added 2 commits March 31, 2023 11:38

Merge branch 'master' into feature/plugins_mount_content

4cf33ff

[pre-commit.ci] auto fixes from pre-commit.com hooks

84252e4

for more information, see https://pre-commit.ci

github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 31, 2023

ethanwharris and others added 5 commits March 31, 2023 16:16

Fixes

d65d3ce

Merge branch 'feature/plugins_mount_content' of github.com:Lightning-…

971937f

…AI/lightning into feature/plugins_mount_content

[pre-commit.ci] auto fixes from pre-commit.com hooks

2d86f27

for more information, see https://pre-commit.ci

Fix

4eadb68

Merge branch 'feature/plugins_mount_content' of github.com:Lightning-…

a749472

…AI/lightning into feature/plugins_mount_content

ethanwharris changed the title ~~Mount content for plugins~~ [App] Mount content for plugins Mar 31, 2023

stale bot added the won't fix This will not be worked on label Apr 14, 2023

ethanwharris removed the won't fix This will not be worked on label May 15, 2023

Merge branch 'master' into feature/plugins_mount_content

d333e7c

github-actions bot removed the pl Generic label for PyTorch Lightning package label May 15, 2023

ethanwharris and others added 3 commits May 15, 2023 12:48

Merge branch 'master' into feature/plugins_mount_content

220af02

Merge branch 'master' into feature/plugins_mount_content

81517c5

Merge branch 'master' into feature/plugins_mount_content

87079ef

ethanwharris marked this pull request as ready for review May 21, 2023 13:01

ethanwharris requested review from tchaton, lantiga and awaelchli as code owners May 21, 2023 13:01

Fix path

dab17e3

Borda approved these changes May 23, 2023

View reviewed changes

src/lightning/app/runners/cloud.py Show resolved Hide resolved

ethanwharris changed the title ~~[App] Mount content for plugins~~ [App] Content for plugins Jun 15, 2023

lantiga and others added 6 commits June 16, 2023 15:40

Merge branch 'master' into feature/plugins_mount_content

dea3719

Merge branch 'master' into feature/plugins_mount_content

6980dc0

Merge branch 'master' into feature/plugins_mount_content

b41b242

Merge branch 'master' into feature/plugins_mount_content

0cd0037

Fixes

19831f0

Merge branch 'feature/plugins_mount_content' of https://github.com/Li…

7396ef6

…ghtning-AI/lightning into feature/plugins_mount_content

justusschock approved these changes Jul 7, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jul 7, 2023

tchaton approved these changes Jul 7, 2023

View reviewed changes

ethanwharris merged commit 2c3dfc0 into master Jul 7, 2023
75 of 87 checks passed

ethanwharris deleted the feature/plugins_mount_content branch July 7, 2023 10:06

awaelchli added this to the 2.0.x milestone Jul 7, 2023

Borda pushed a commit that referenced this pull request Jul 7, 2023

[App] Content for plugins (#17243)

8a8cbf7

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> (cherry picked from commit 2c3dfc0)

Borda pushed a commit that referenced this pull request Jul 7, 2023

[App] Content for plugins (#17243)

a8fd96b

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> (cherry picked from commit 2c3dfc0)

lantiga pushed a commit that referenced this pull request Jul 10, 2023

[App] Content for plugins (#17243)

aadc150

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai> Co-authored-by: Luca Antiga <luca.antiga@gmail.com> (cherry picked from commit 2c3dfc0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App] Content for plugins #17243

[App] Content for plugins #17243

ethanwharris commented Mar 31, 2023 •

edited by github-actions bot

stale bot commented Apr 14, 2023

github-actions bot commented May 21, 2023 •

edited

tchaton left a comment

[App] Content for plugins #17243

[App] Content for plugins #17243

Conversation

ethanwharris commented Mar 31, 2023 • edited by github-actions bot

What does this PR do?

PR review

stale bot commented Apr 14, 2023

github-actions bot commented May 21, 2023 • edited

⚡ Required checks status: All passing 🟢

Groups summary

tchaton left a comment

Choose a reason for hiding this comment

ethanwharris commented Mar 31, 2023 •

edited by github-actions bot

github-actions bot commented May 21, 2023 •

edited