Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy from Callback scripts #17267

Merged

Conversation

ishandutta0098
Copy link
Contributor

What does this PR do?

This PR is a part of #16649

I have replaced the use of np.Inf and np.nan with float('inf') and float('nan') for the following scripts:

  • model_checkpoint.py
  • early_stopping.py
  • test_early_stopping.py
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Requesting Review: @carmocca @Borda

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 3, 2023
@mergify mergify bot added the has conflicts label Apr 3, 2023
@mergify mergify bot removed the has conflicts label Apr 3, 2023
@awaelchli awaelchli added refactor community This PR is from the community labels Apr 3, 2023
@mergify mergify bot added the ready PRs ready to be merged label Apr 3, 2023
@awaelchli awaelchli enabled auto-merge (squash) April 4, 2023 11:01
@awaelchli awaelchli merged commit 6cbc9df into Lightning-AI:master Apr 4, 2023
@ishandutta0098 ishandutta0098 deleted the numpy_to_torch_callbacks branch April 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants