Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: label issue with version #17484

Merged
merged 7 commits into from
Apr 27, 2023
Merged

ci: label issue with version #17484

merged 7 commits into from
Apr 27, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 26, 2023

What does this PR do?

As we introduced label option #17226 we want also parse this information to label so we can filter issues

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca

@github-actions github-actions bot added app (removed) Generic label for Lightning App package ci Continuous Integration labels Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Apr 26, 2023
@Borda Borda enabled auto-merge (squash) April 26, 2023 19:10
.github/labeler.yml Outdated Show resolved Hide resolved
.github/workflows/issue-labeler.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1_bug_report.yaml Show resolved Hide resolved
@Borda Borda requested a review from carmocca April 27, 2023 09:36
.github/labeler.yml Outdated Show resolved Hide resolved
@Borda Borda self-assigned this Apr 27, 2023
@mergify mergify bot added the ready PRs ready to be merged label Apr 27, 2023
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
@Borda Borda merged commit 3a01abb into master Apr 27, 2023
12 checks passed
@Borda Borda deleted the ci/labeler branch April 27, 2023 14:15
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's not right. Bug reports cannot be created

@Borda Borda mentioned this pull request Apr 27, 2023
7 tasks
@awaelchli
Copy link
Member

awaelchli commented Apr 27, 2023

@carmocca it seems to work for me: #17496 #17497

@carmocca
Copy link
Contributor

Jirka pushed a fix before you tried: 8684783

Borda added a commit that referenced this pull request Jun 1, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 3a01abb)
lantiga pushed a commit that referenced this pull request Jun 2, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit 3a01abb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants