Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App: change cache location #17491

Merged
merged 17 commits into from
May 4, 2023
Merged

App: change cache location #17491

merged 17 commits into from
May 4, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 27, 2023 •
edited by github-actions bot
Loading

What does this PR do?

make cache dondional

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Apr 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
pl-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
pl-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11) success ✅
pl-cpu (windows-2022, lightning, 3.9, 1.12) success ✅
pl-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.0) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success ✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to pyproject.toml.

🟢 fabric: Docs
Check ID Status
make-doctest (fabric) success ✅
make-html (fabric) success ✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success ✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success ✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success ✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success ✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success ✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success ✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success ✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success ✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, tests/tests_app/source_code/test_local.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, tests/integrations_app/public/test_boring_app.py.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, tests/integrations_app/public/test_boring_app.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, pyproject.toml.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py, pyproject.toml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, src/lightning/app/source_code/local.py.

🟢 link-check
Check ID Status
check-md-links / markdown-link-check success ✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title Change cache location App: change cache location Apr 27, 2023
@Borda Borda self-requested a review April 27, 2023 10:50
awaelchli
awaelchli approved these changes Apr 27, 2023
View reviewed changes
src/lightning/app/source_code/local.py Outdated Show resolved Hide resolved
src/lightning/app/CHANGELOG.md Outdated Show resolved Hide resolved
@tchaton @awaelchli
Update src/lightning/app/source_code/local.py
be840e7 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@mergify mergify bot added the ready PRs ready to be merged label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #17491 (5808386) into master (db9f095) will decrease coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17491   +/-   ##
=======================================
- Coverage      84%      84%   -0%     
=======================================
  Files         414      414           
  Lines       31753    31763   +10     
=======================================
+ Hits        26537    26540    +3     
- Misses       5216     5223    +7

@tchaton
Copy link
Contributor Author

tchaton commented Apr 27, 2023

@awaelchli Any ideas ?

@awaelchli
Copy link
Member

@tchaton What is the question? About the failing jobs? They are sometimes flaky

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 28, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 28, 2023
@tchaton tchaton enabled auto-merge (squash) May 4, 2023 07:26
@tchaton tchaton merged commit 7df627b into master May 4, 2023
@tchaton tchaton deleted the change_cache_location branch May 4, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@awaelchli awaelchli awaelchli approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tchaton @awaelchli @Borda @carmocca