New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get project #17617

Merged

williamFalcon merged 5 commits into master from fix/get_project

May 12, 2023

Member

yurijmikhalevich commented May 12, 2023 •

edited by github-actions bot

What does this PR do?

Fixes the internal get project helper.

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified


          fix: get project

93a22e8

yurijmikhalevich requested review from tchaton, lantiga, awaelchli and ethanwharris as code owners

May 12, 2023 11:45

github-actions bot added the app label

Contributor

github-actions bot commented May 12, 2023 •

edited

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py, tests/tests_app/utilities/test_cloud.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py.

🔴 lightning_app: Azure

Check ID	Status
App.cloud-e2e	failure	❌

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/core/constants.py, src/lightning/app/utilities/cloud.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM !

Mind adding a test ?


          test

60d51ac

yurijmikhalevich force-pushed the fix/get_project branch from 384d375 to 60d51ac Compare

May 12, 2023 12:12

ethanwharris approved these changes

View reviewed changes

yurijmikhalevich enabled auto-merge (squash)

May 12, 2023 12:13

mergify bot added the ready label


          fix tests

bad6e32

yurijmikhalevich force-pushed the fix/get_project branch from 1558786 to bad6e32 Compare

May 12, 2023 12:28


          fix tests

7eeabc9

yurijmikhalevich force-pushed the fix/get_project branch from a662ecb to 7eeabc9 Compare

May 12, 2023 13:06


          [pre-commit.ci] auto fixes from pre-commit.com hooks

5b73cac

for more information, see https://pre-commit.ci

justusschock approved these changes

View reviewed changes

williamFalcon disabled auto-merge

May 12, 2023 14:03

williamFalcon merged commit 266a4f1 into master

82 of 85 checks passed

williamFalcon deleted the fix/get_project branch

May 12, 2023 14:03

yurijmikhalevich added a commit that referenced this pull request


          Revert "fix: get project (#17617)"

047a731

This reverts commit 266a4f1.

Borda pushed a commit that referenced this pull request


          fix: get project (#17617)

a1cae3b

* fix: get project

* test

* fix tests

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 266a4f1)

Borda pushed a commit that referenced this pull request


          fix: get project (#17617)

dd129b9

* fix: get project

* test

* fix tests

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 266a4f1)

lantiga pushed a commit that referenced this pull request


          fix: get project (#17617)

83fe1a3

* fix: get project

* test

* fix tests

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 266a4f1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanwharris ethanwharris approved these changes

tchaton tchaton approved these changes

justusschock justusschock approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

awaelchli Awaiting requested review from awaelchli awaelchli is a code owner