Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mix Precision settings for FSDP Plugins #17670

Merged
merged 4 commits into from
May 23, 2023

Conversation

leng-yue
Copy link
Contributor

@leng-yue leng-yue commented May 21, 2023

What does this PR do?

This pull request has made changes to the Fabric and PyTorch FSDP Plugins, enabling them to handle mixed-precision training properly.

Fixes #17506

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels May 21, 2023
@leng-yue leng-yue marked this pull request as ready for review May 21, 2023 04:34
@carmocca carmocca added the strategy: fsdp Fully Sharded Data Parallel label May 21, 2023
@carmocca carmocca added this to the 2.0.x milestone May 21, 2023
src/lightning/pytorch/CHANGELOG.md Outdated Show resolved Hide resolved
@Borda Borda merged commit 2c8758f into Lightning-AI:master May 23, 2023
99 checks passed
@mergify mergify bot added the ready PRs ready to be merged label May 23, 2023
Borda pushed a commit that referenced this pull request Jun 2, 2023
lantiga pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fsdp Fully Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent settings for FSDP Precision
3 participants