Expose public and private IP in LightningWork #17742

awaelchli · 2023-06-01T18:39:42Z

What does this PR do?

Redefines LightningWork.internal_ip as the private ip. Initially this used to be the case, then at some point the platform re-defined it as public IP and so it was misleading until now.
Adds LightningWork.public_ip with the actual public IP (previously internal_ip)

cc @Borda

review-notebook-app · 2023-06-01T18:39:46Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2023-06-01T22:31:52Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/structures/test_structures.py, tests/tests_app/utilities/test_proxies.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 link-check

Check ID	Status
check-md-links / markdown-link-check	success	✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

for more information, see https://pre-commit.ci

tchaton

LGTM !

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

ip

ca2a90b

github-actions bot added app Generic label for Lightning App package pl Generic label for PyTorch Lightning package labels Jun 1, 2023

reset

570d74b

github-actions bot removed the pl Generic label for PyTorch Lightning package label Jun 1, 2023

update test

8e719c3

awaelchli marked this pull request as ready for review June 1, 2023 22:31

awaelchli requested review from tchaton, lantiga and ethanwharris as code owners June 1, 2023 22:31

awaelchli added the feature Is an improvement or enhancement label Jun 1, 2023

awaelchli added this to the 2.0.x milestone Jun 1, 2023

pre-commit-ci bot and others added 3 commits June 1, 2023 22:32

[pre-commit.ci] auto fixes from pre-commit.com hooks

7f5bb2f

for more information, see https://pre-commit.ci

fix

88e94dc

update

2da6c6a

awaelchli changed the title ~~WIP: Expose public and private IP in LightningWork~~ Expose public and private IP in LightningWork Jun 2, 2023

tchaton approved these changes Jun 2, 2023

View reviewed changes

awaelchli added 3 commits June 4, 2023 22:06

Merge branch 'master' into feature/app-public-ip

f22e5aa

changelog

93796d7

reset

c3fbc45

justusschock approved these changes Jun 5, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jun 5, 2023

reset

045d19f

awaelchli enabled auto-merge (squash) June 6, 2023 10:42

awaelchli merged commit d23c772 into master Jun 6, 2023
86 checks passed

awaelchli deleted the feature/app-public-ip branch June 6, 2023 11:35

awaelchli added a commit that referenced this pull request Jun 7, 2023

Expose public and private IP in LightningWork (#17742)

e17fa43

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Borda pushed a commit that referenced this pull request Jun 7, 2023

Expose public and private IP in LightningWork (#17742)

09e0fff

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

lantiga pushed a commit that referenced this pull request Jun 7, 2023

Expose public and private IP in LightningWork (#17742)

cf1838f

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose public and private IP in LightningWork #17742

Expose public and private IP in LightningWork #17742

awaelchli commented Jun 1, 2023 •

edited

review-notebook-app bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023 •

edited

tchaton left a comment

Expose public and private IP in LightningWork #17742

Expose public and private IP in LightningWork #17742

Conversation

awaelchli commented Jun 1, 2023 • edited

What does this PR do?

review-notebook-app bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023 • edited

⚡ Required checks status: All passing 🟢

Groups summary

tchaton left a comment

Choose a reason for hiding this comment

awaelchli commented Jun 1, 2023 •

edited

github-actions bot commented Jun 1, 2023 •

edited