Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin): store source app #17892

Merged
merged 6 commits into from
Jun 22, 2023
Merged

feat(plugin): store source app #17892

merged 6 commits into from
Jun 22, 2023

Conversation

yurijmikhalevich
Copy link
Member

@yurijmikhalevich yurijmikhalevich commented Jun 21, 2023 •
edited by github-actions bot

What does this PR do?

The PR makes plugin server accept and store pluginId.

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@github-actions github-actions bot added the app Generic label for Lightning App package label Jun 21, 2023
@yurijmikhalevich yurijmikhalevich changed the title feat: store pluginId feat: store plugin name Jun 21, 2023
@yurijmikhalevich yurijmikhalevich changed the title feat: store plugin name feat(plugin): store source app Jun 22, 2023
@yurijmikhalevich yurijmikhalevich marked this pull request as ready for review June 22, 2023 11:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, tests/tests_app/plugin/test_plugin.py, requirements/app/base.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, requirements/app/base.txt.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success ✅
make-html (app) success ✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, requirements/app/base.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/base.txt, src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/app/plugin/plugin.py, src/lightning/app/runners/cloud.py, requirements/app/base.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda added this to the 2.0.x milestone Jun 22, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jun 22, 2023
tchaton
tchaton approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurijmikhalevich yurijmikhalevich enabled auto-merge (squash) June 22, 2023 12:53
@yurijmikhalevich yurijmikhalevich merged commit 60f2e3a into master Jun 22, 2023
83 of 85 checks passed
@yurijmikhalevich yurijmikhalevich deleted the feat/plugin-update branch June 22, 2023 15:57
Borda pushed a commit that referenced this pull request Jul 7, 2023
@yurijmikhalevich @Borda
feat(plugin): store source app (#17892)
6e4613c 
(cherry picked from commit 60f2e3a)
lantiga pushed a commit that referenced this pull request Jul 10, 2023
@yurijmikhalevich @lantiga
feat(plugin): store source app (#17892)
a341f1a 
(cherry picked from commit 60f2e3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@nohalon nohalon nohalon approved these changes

@tchaton tchaton tchaton approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees
No one assigned
Labels
app Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yurijmikhalevich @Borda @nohalon @tchaton