Check all param groups for flat parameters in FSDP #17914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-ai
requested review from
awaelchli,
carmocca,
justusschock,
lantiga,
Borda and
tchaton
as code owners
awaelchli
changed the title
awaelchli
approved these changes
Jun 26, 2023
awaelchli
added
strategy: fsdp
carmocca
approved these changes
Jun 26, 2023
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
Co-authored-by: awaelchli <aedu.waelchli@gmail.com> (cherry picked from commit 9337d1c)
7 tasks
lantiga
pushed a commit
that referenced
this pull request
Jul 10, 2023
Co-authored-by: awaelchli <aedu.waelchli@gmail.com> (cherry picked from commit 9337d1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17817