-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fetch external sources #17941
docs: fetch external sources #17941
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_app: Docs
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
okk, it seems that Sphinx does not include resources linked only in HTML section
Consider replacement with https://github.com/sphinx-contrib/video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no docs preview so I don't really know what I'm approving 🤞
there is, see the checks: https://pytorch-lightning--17941.org.readthedocs.build/en/17941/ |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 00a0f2e)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 00a0f2e)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 00a0f2e)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 00a0f2e)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 00a0f2e)
What does this PR do?
making docs as standalone resources without needing to pull S3 assets
pending on Lightning-AI/utilities#142
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @tchaton @carmocca @justusschock @awaelchli