Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of the best model's path saved by ModelCheckpoint #1799

Merged
merged 15 commits into from
May 31, 2020
Merged

Keep track of the best model's path saved by ModelCheckpoint #1799

merged 15 commits into from
May 31, 2020

Commits on May 19, 2020

  1. Add an additional attribute to ModelCheckpoint to keep track of the b… 

    …est model's path

Currently, only the best metric value is directly tracked. This new attribute will help in uses cases where the trained model needs to be used or tracked right after training.
    @kepler
    kepler committed May 19, 2020
    Configuration menu
    Copy the full SHA
    ed3e6f3 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. Add small description and usage example to docs

    @kepler
    kepler committed May 27, 2020
    Configuration menu
    Copy the full SHA
    33ea275 View commit details
    Browse the repository at this point in the history

  2. Fix PEP8 issues

    @kepler
    kepler committed May 27, 2020
    Configuration menu
    Copy the full SHA
    5fe9a58 View commit details
    Browse the repository at this point in the history

  3. Fix doctest example

    @kepler
    kepler committed May 27, 2020
    Configuration menu
    Copy the full SHA
    7a92c00 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Fix expected output in doctest

    @kepler
    kepler committed May 28, 2020
    Configuration menu
    Copy the full SHA
    1434249 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @Borda
    Borda committed May 28, 2020
    Configuration menu
    Copy the full SHA
    648c152 View commit details
    Browse the repository at this point in the history

  3. Show example as code block instead of doctest

    @kepler
    kepler committed May 28, 2020
    Configuration menu
    Copy the full SHA
    8c59480 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @Borda
    Borda committed May 28, 2020
    Configuration menu
    Copy the full SHA
    0ee63a9 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md

    @kepler
    kepler committed May 28, 2020
    Configuration menu
    Copy the full SHA
    24c27a0 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Rename ModelCheckpoint.best to ModelCheckpoint.best_model_score 

    Also rename `ModelCheckpoint.best_model` (added in this PR) to `ModelCheckpoint.best_model_path`, for consistency, and `kth_best_model` to `kth_best_model_path`.
    @kepler
    kepler committed May 29, 2020
    Configuration menu
    Copy the full SHA
    3f4901d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/keep-track-of-best-model

    @kepler
    kepler committed May 29, 2020
    Configuration menu
    Copy the full SHA
    5a7ea43 View commit details
    Browse the repository at this point in the history

  3. Update pytorch_lightning/trainer/training_io.py 

    Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
    @kepler @Borda
    kepler and Borda committed May 29, 2020
    Configuration menu
    Copy the full SHA
    f09372f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
    @kepler @Borda
    kepler and Borda committed May 29, 2020
    Configuration menu
    Copy the full SHA
    bc2baad View commit details
    Browse the repository at this point in the history

Commits on May 31, 2020

  1. Add warning when loading checkpoint from an old version

    @kepler
    kepler committed May 31, 2020
    Configuration menu
    Copy the full SHA
    ac36651 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/keep-track-of-best-model

    @kepler
    kepler committed May 31, 2020
    Configuration menu
    Copy the full SHA
    7b8a633 View commit details
    Browse the repository at this point in the history