Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightningCLI not saving correctly seed_everything for run=True #18056

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

mauvilsa
Copy link
Contributor

What does this PR do?

Fixes a bug in LightningCLI where the saved config does not save the actual value used for seed_everything. The intention of the saved config is reproducibility, and by not having the correct seed_everything, it is not possible to reproduce. The bug only affects run=True and seed_everything=True (the default).

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 11, 2023
@mauvilsa mauvilsa force-pushed the cli-fix-seed-everything-save branch from b879937 to 811817b Compare July 11, 2023 05:16
@mauvilsa mauvilsa marked this pull request as ready for review July 11, 2023 05:17
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

tests/tests_pytorch/test_cli.py Show resolved Hide resolved
@carmocca carmocca added bug Something isn't working lightningcli pl.cli.LightningCLI labels Jul 11, 2023
@carmocca carmocca added this to the 2.0.x milestone Jul 11, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jul 12, 2023
@Borda Borda changed the title Fix LightningCLI not saving correctly seed_everything for run=True Fix LightningCLI not saving correctly seed_everything for run=True Jul 12, 2023
@Borda Borda merged commit e38c71b into Lightning-AI:master Jul 12, 2023
79 checks passed
@mauvilsa mauvilsa deleted the cli-fix-seed-everything-save branch July 12, 2023 11:13
Borda pushed a commit that referenced this pull request Jul 19, 2023
lantiga pushed a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants