Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google Cloud Storage checkpointing #18088

Merged
merged 20 commits into from
Aug 1, 2023
Merged

Fix Google Cloud Storage checkpointing #18088

merged 20 commits into from
Aug 1, 2023

Conversation

bilelomrani1
Copy link
Contributor

@bilelomrani1 bilelomrani1 commented Jul 15, 2023 •
edited

What does this PR do?

This PR fixes an issue when using Google Storage as the Trainer's root directory, which failed because fs.makedirs is a no-op with GCS.

Fixes #18044

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jul 15, 2023
@bilelomrani1 bilelomrani1 marked this pull request as ready for review July 15, 2023 02:35
awaelchli
awaelchli reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks reasonable to me! Great work. I left minor comments.

src/lightning/fabric/utilities/cloud_io.py Outdated Show resolved Hide resolved
src/lightning/fabric/utilities/cloud_io.py Outdated Show resolved Hide resolved
src/lightning/fabric/utilities/cloud_io.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added checkpointing Related to checkpointing bug Something isn't working labels Jul 15, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Jul 15, 2023
@awaelchli awaelchli added the 3rd party Related to a 3rd-party label Jul 15, 2023
@awaelchli awaelchli self-assigned this Jul 15, 2023
@awaelchli awaelchli self-requested a review July 18, 2023 10:55
awaelchli
awaelchli approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a minor comment. Thanks for adding the requested tests 🎉

src/lightning/fabric/utilities/cloud_io.py Outdated Show resolved Hide resolved
@awaelchli awaelchli requested a review from Borda July 26, 2023 12:48
@awaelchli awaelchli requested a review from Borda July 28, 2023 09:36
justusschock
justusschock approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only concern I have is that this special cases the 3 cloud providers but this fix wouldn't apply for every other potentially more niche storage backend with the same limitations

@mergify mergify bot added the ready PRs ready to be merged label Jul 31, 2023
@Borda Borda merged commit b4435bd into Lightning-AI:master Aug 1, 2023
100 checks passed
@bilelomrani1 bilelomrani1 mentioned this pull request Aug 3, 2023
Merged
7 tasks
Borda pushed a commit that referenced this pull request Aug 14, 2023
@bilelomrani1 @Borda
Fix Google Cloud Storage checkpointing (#18088)
b9872f4 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

(cherry picked from commit b4435bd)
lexierule pushed a commit that referenced this pull request Aug 14, 2023
@bilelomrani1 @lexierule
Fix Google Cloud Storage checkpointing (#18088)
ab573cc 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

(cherry picked from commit b4435bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@awaelchli awaelchli

Labels
3rd party Related to a 3rd-party bug Something isn't working checkpointing Related to checkpointing fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.

Missing folder exception with Google Cloud Storage checkpointing
4 participants
@bilelomrani1 @awaelchli @Borda @justusschock