Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/wandb logger callback #18253

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Refactor/wandb logger callback #18253

wants to merge 19 commits into from
+29 −1

Conversation

schmidt-ai
Copy link
Contributor

Closes #17913.

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 7, 2023
@schmidt-ai schmidt-ai marked this pull request as ready for review August 8, 2023 18:52
@schmidt-ai
Copy link
Contributor Author

@awaelchli wdyt of this PR?

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 17, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited

Codecov Report

Merging #18253 (1f84632) into master (49caddd) will decrease coverage by 36%.
The diff coverage is 100%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18253      +/-   ##
==========================================
- Coverage      84%      47%     -36%     
==========================================
  Files         443      435       -8     
  Lines       36162    36011     -151     
==========================================
- Hits        30268    17077   -13191     
- Misses       5894    18934   +13040

@stale stale bot removed the won't fix This will not be worked on label Oct 4, 2023
schmidt-ai and others added 2 commits November 21, 2023 11:17
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 16, 2024 •
edited

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@jglaser
Copy link

jglaser commented Feb 28, 2024

is this still being worked on?

@schmidt-ai
Copy link
Contributor Author

No, sorry; this fell off my radar... I think we just need test coverage? CC @awaelchli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WandbLogger callback for customizing checkpoint artifact logging
3 participants
@schmidt-ai @jglaser @Borda