Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci for legacy upload #18316

Merged
merged 2 commits into from
Aug 15, 2023
Merged

update ci for legacy upload #18316

merged 2 commits into from
Aug 15, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 15, 2023

What does this PR do?

Need to upload generated checkpoint, ref: https://github.com/Lightning-AI/lightning/actions/runs/5869958812/job/15916082742

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @Borda @awaelchli @tchaton

@Borda Borda added ci Continuous Integration release checkpointing Related to checkpointing labels Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to docs/source-pytorch/upgrade/migration_guide.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested a review from a team August 15, 2023 20:09
@Borda Borda added the priority: 1 Medium priority task label Aug 15, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 15, 2023
@williamFalcon williamFalcon merged commit c98fb36 into master Aug 15, 2023
19 checks passed
@williamFalcon williamFalcon deleted the ci/s3-user branch August 15, 2023 21:32
Borda added a commit that referenced this pull request Aug 15, 2023
* update ci for legacy upload

* docs

(cherry picked from commit c98fb36)
lantiga pushed a commit that referenced this pull request Aug 16, 2023
* update ci for legacy upload

* docs

(cherry picked from commit c98fb36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing ci Continuous Integration pl Generic label for PyTorch Lightning package priority: 1 Medium priority task release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants