Properly manage fetcher.done with dataloader_iter
#18376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
bug
carmocca
commented
Aug 23, 2023
carmocca
requested review from
awaelchli,
justusschock,
Borda and
williamFalcon
as code owners
awaelchli
approved these changes
Aug 23, 2023
Borda
approved these changes
Aug 24, 2023
Borda
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 9496d9a)
Borda
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 9496d9a)
awaelchli
reviewed
Aug 30, 2023
| @@ -42,24 +43,28 @@ def combined_loader(self) -> CombinedLoader: | |||
|
|
|||
| def setup(self, combined_loader: CombinedLoader) -> None: | |||
| self._combined_loader = combined_loader | |||
| self.length = sized_len(combined_loader) | |||
There was a problem hiding this comment.
I'm exploring some ideas how we could make this length respect the limit_x_batches settings from the loop: #18436
lantiga
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit 9496d9a)
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
data_fetcher.doneto be consistent with regular data fetchers.dataloader_iter.{done,length,fetched}publiccc @justusschock @awaelchli @Borda