Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for trainer.test() #1858

Merged
merged 2 commits into from
May 17, 2020
Merged

Conversation

Varal7
Copy link
Contributor

@Varal7 Varal7 commented May 16, 2020

Fixes #1857

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1857.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team May 16, 2020 23:39
@williamFalcon
Copy link
Contributor

can you add a test for this? this is great!

@awaelchli
Copy link
Member

see also #1804, is it not the same?

@pep8speaks
Copy link

pep8speaks commented May 17, 2020

Hello @Varal7! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-17 15:02:52 UTC

@Varal7
Copy link
Contributor Author

Varal7 commented May 17, 2020

Indeed there seems to be work ongoing in #1804, #1720, #1754, #1804 already.

I wrote a test case just in case.

@williamFalcon
Copy link
Contributor

@Varal7 can you rebase with master and double check that this works?

The test is still useful!

@williamFalcon williamFalcon changed the title fix trainer.test() add test for trainer.test() May 17, 2020
@williamFalcon williamFalcon added the ready PRs ready to be merged label May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use Trainer.test() if train and val dataloaders are not defined
4 participants