Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinghtningCLI now will not allow setting a class instance as a default #18822

Merged

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Oct 19, 2023

What does this PR do?

Fixes #18731

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

馃摎 Documentation preview 馃摎: https://pytorch-lightning--18822.org.readthedocs.build/en/18822/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Oct 19, 2023
@mauvilsa mauvilsa force-pushed the cli-issue-18731-instance-defaults branch from 6caf334 to ef8bdf8 Compare October 19, 2023 05:27
@awaelchli awaelchli added this to the 2.2 milestone Oct 19, 2023
@awaelchli awaelchli added lightningcli pl.cli.LightningCLI community This PR is from the community labels Oct 19, 2023
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mauvilsa, this is great!

@mauvilsa mauvilsa force-pushed the cli-issue-18731-instance-defaults branch from ef8bdf8 to 9b08fff Compare October 23, 2023 05:56
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #18822 (9b08fff) into master (c68ff64) will decrease coverage by 35%.
Report is 3 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18822      +/-   ##
==========================================
- Coverage      83%      48%     -35%     
==========================================
  Files         442      434       -8     
  Lines       35109    35017      -92     
==========================================
- Hits        29173    16880   -12293     
- Misses       5936    18137   +12201     

Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot added the ready PRs ready to be merged label Oct 23, 2023
@awaelchli awaelchli merged commit c5a731c into Lightning-AI:master Oct 24, 2023
105 checks passed
@mauvilsa mauvilsa deleted the cli-issue-18731-instance-defaults branch October 24, 2023 04:32
@Borda Borda modified the milestones: 2.2, 2.1.x Nov 2, 2023
Borda pushed a commit that referenced this pull request Dec 20, 2023
lantiga pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community dependencies Pull requests that update a dependency file lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightningCLI trainer_defaults get dumped as Python object
4 participants