Refined FSDP saving logic and error messaging when path exists #18884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
for more information, see https://pre-commit.ci
…ture/fsdp-overwrite
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
awaelchli
added
bug
carmocca
approved these changes
Oct 28, 2023
Borda
approved these changes
Oct 30, 2023
Borda
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit e66be67)
Borda
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit e66be67)
lantiga
pushed a commit
that referenced
this pull request
Nov 6, 2023
(cherry picked from commit e66be67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, The FSDP strategy raises an error when you attempt to save a checkpoint to a folder that exists. This is to avoid losing files due to overwriting/deleting an entire folder (which accidentally may not be a checkpoint folder).
#18873 proposes to add an argument to
Fabric.save()to force the deletion, but this would makeFabric.save()diverge too much from howtorch.save()works in my opinion. Instead, I propose to loosen the check and do the following:In all other cases we overwrite anyway (torch.save overwrites). This should solve the issue the user is facing.
Fixes #18873
Part of #18881
📚 Documentation preview 📚: https://pytorch-lightning--18884.org.readthedocs.build/en/18884/
cc @Borda @carmocca @justusschock @awaelchli