Fix parsing of version in TensorBoardLogger and CSVLogger #18897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
awaelchli
added
bug
github-actions
bot
added
fabric
carmocca
approved these changes
Oct 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18897 +/- ##
=========================================
- Coverage 75% 53% -23%
=========================================
Files 447 442 -5
Lines 35826 35732 -94
=========================================
- Hits 27016 18863 -8153
- Misses 8810 16869 +8059 |
Borda
approved these changes
Oct 31, 2023
Borda
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 98685c3)
Borda
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 98685c3)
Borda
pushed a commit
that referenced
this pull request
Nov 2, 2023
(cherry picked from commit 98685c3)
lantiga
pushed a commit
that referenced
this pull request
Nov 6, 2023
(cherry picked from commit 98685c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #17691
Edge case in parsing the version from folders. If a folder doesn't have a version number, we skip it now instead of trying to call
int()on a character string.cc @Borda @awaelchli @carmocca @justusschock