Fix fsspec local file protocol checks for new fsspec version #19023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
awaelchli
requested review from
carmocca,
justusschock and
williamFalcon
as code owners
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19023 +/- ##
=========================================
+ Coverage 76% 83% +8%
=========================================
Files 443 443
Lines 36120 36123 +3
=========================================
+ Hits 27303 30025 +2722
+ Misses 8817 6098 -2719 |
awaelchli
changed the title
carmocca
approved these changes
Nov 18, 2023
Borda
approved these changes
Nov 18, 2023
Borda
pushed a commit
that referenced
this pull request
Dec 19, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit b8a96fe)
lantiga
pushed a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit b8a96fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fsspec library changed the protocol return value in their 2023.10 release: https://github.com/fsspec/filesystem_spec/pull/1381/files
We need to update our checks for
get_filesystem().protocol == "file"to work around the change depending on the fsspec version. This fixes the tests that we see failing on master.Since this affects the core checkpointing experience, and everyone installing lightning fresh, this needs to be prioritized.
cc @Borda @tchaton @carmocca @justusschock @awaelchli