Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix num batches in case of multiple dataloaders and percent_check #1920

Merged
merged 16 commits into from
Jun 18, 2020
Merged

Fix num batches in case of multiple dataloaders and percent_check #1920

merged 16 commits into from
Jun 18, 2020

Commits on Jun 17, 2020

  1. fixing docs (#2227)

    @Borda
    Borda committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a5f7c63 View commit details
    Browse the repository at this point in the history

  2. Fix num_batches in case of multiple dataloaders

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8a1bb94 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @awaelchli @rohitgr7
    awaelchli authored and rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    14f434d View commit details
    Browse the repository at this point in the history

  4. Changes based on suggestions

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c616772 View commit details
    Browse the repository at this point in the history

  5. Flake8

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8d58b4b View commit details
    Browse the repository at this point in the history

  6. Add test to check num_batches

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    18e2746 View commit details
    Browse the repository at this point in the history

  7. generalize dataloader percent check test

    @awaelchli @rohitgr7
    awaelchli authored and rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    4ca768c View commit details
    Browse the repository at this point in the history

  8. fix formatting

    @awaelchli @rohitgr7
    awaelchli authored and rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    eb3c164 View commit details
    Browse the repository at this point in the history

  9. remove hparams

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1d2155a View commit details
    Browse the repository at this point in the history

  10. tests

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    721556e View commit details
    Browse the repository at this point in the history

  11. CHANGELOG

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    aa86e72 View commit details
    Browse the repository at this point in the history

  12. Update CHANGELOG.md

    @Borda @rohitgr7
    Borda authored and rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    511c35a View commit details
    Browse the repository at this point in the history

  13. max_batches can be int

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    cddc2d8 View commit details
    Browse the repository at this point in the history

  14. conflict and rebase

    @rohitgr7
    rohitgr7 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    5e684ea View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. git conflict

    @Borda
    Borda committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5f18d9a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'num_batches_missing_test' into fix_num_batches

    @Borda
    Borda committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    18c9581 View commit details
    Browse the repository at this point in the history