Scale mmt #19984

tchaton · 2024-06-17T15:10:05Z

What does this PR do?

This PR optimizes MMT startup time.

Fixes #<issue_number>

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19984.org.readthedocs.build/en/19984/

cc @Borda @carmocca @justusschock @awaelchli

for more information, see https://pre-commit.ci

github-actions · 2024-06-17T15:10:52Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.3)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 2.0)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/cli.py, pyproject.toml.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to pyproject.toml, src/lightning/fabric/cli.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to src/lightning/fabric/cli.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/cli.py, pyproject.toml.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-11, lightning, 3.11, 2.2)	success	✅
fabric-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 2.0, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to src/lightning/fabric/cli.py, pyproject.toml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to src/lightning/fabric/cli.py, pyproject.toml.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (macOS-12, app, 3.11, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (ubuntu-22.04, app, 3.11, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.11, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/utilities/proxies.py, src/lightning_app/__main__.py, tests/tests_app/cli/test_cli.py, tests/tests_app/cli/test_cmd_launch.py, tests/tests_app/components/multi_node/test_trainer.py, tests/tests_app/core/test_constants.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_work.py, tests/tests_app/core/test_queues.py, tests/tests_app/launcher/test_running_flow.py, tests/tests_app/storage/test_path.py, tests/tests_app/utilities/test_proxies.py, requirements/app/app.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/utilities/proxies.py, src/lightning_app/__main__.py, requirements/app/app.txt.

🟢 lightning_app: Docs

Check ID	Status
docs-make (app, doctest)	success	✅
docs-make (app, html)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/utilities/proxies.py, src/lightning_app/__main__.py, requirements/app/app.txt, pyproject.toml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/app.txt, src/lightning/app/cli/lightning_cli.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/utilities/proxies.py, src/lightning/fabric/cli.py, src/lightning_app/__main__.py, pyproject.toml.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/app/cli/lightning_cli.py, src/lightning/app/core/app.py, src/lightning/app/core/constants.py, src/lightning/app/core/queues.py, src/lightning/app/core/work.py, src/lightning/app/launcher/launcher.py, src/lightning/app/launcher/lightning_backend.py, src/lightning/app/launcher/lightning_hybrid_backend.py, src/lightning/app/launcher/utils.py, src/lightning/app/runners/backends/backend.py, src/lightning/app/utilities/proxies.py, src/lightning/fabric/cli.py, src/lightning_app/__main__.py, requirements/app/app.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

…ightning into scale_mmt

src/lightning/app/core/queues.py

…ightning into scale_mmt

tchaton added 3 commits June 17, 2024 14:16

update

78dc664

update

77615ae

update

402ac47

tchaton requested review from lantiga, awaelchli and ethanwharris as code owners June 17, 2024 15:10

github-actions bot added the app (removed) Generic label for Lightning App package label Jun 17, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

5a4755c

for more information, see https://pre-commit.ci

tchaton added 17 commits June 17, 2024 16:10

update

2657ba6

update

b77a422

Merge branch 'scale_mmt' of https://github.com/Lightning-AI/pytorch-l…

866177d

…ightning into scale_mmt

update

0c464d0

update

1c41c9e

update

648c940

update

909234b

update

0e3a931

update

0f571ec

update

cd49083

update

1d40f70

update

da3321f

update

384c4e4

update

34d1998

update

72a95b4

update

4456197

update

4eb1df4

lantiga approved these changes Jun 17, 2024

View reviewed changes

src/lightning/app/core/queues.py Outdated Show resolved Hide resolved

src/lightning/app/core/queues.py Outdated Show resolved Hide resolved

src/lightning/app/core/queues.py Outdated Show resolved Hide resolved

src/lightning/app/core/queues.py Outdated Show resolved Hide resolved

tchaton marked this pull request as draft June 17, 2024 20:59

update

6135459

github-actions bot added the dependencies Pull requests that update a dependency file label Jun 17, 2024

tchaton added 4 commits June 21, 2024 19:25

update

9ce5bcc

update

f2edb30

update

e5ab92f

update

30db189

mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 25, 2024

Merge branch 'master' into scale_mmt

842da8c

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 26, 2024

tchaton added 9 commits June 26, 2024 09:00

update

7161c9a

Merge branch 'scale_mmt' of https://github.com/Lightning-AI/pytorch-l…

49ea97e

…ightning into scale_mmt

update

c41a9ab

update

b6f09a8

update

2f05eb0

update

023c0a9

update

4607713

update

00078a0

update

9bbd6ca

justusschock approved these changes Jun 26, 2024

View reviewed changes

update

27eecc0

tchaton merged commit d53e107 into master Jun 26, 2024
141 checks passed

tchaton deleted the scale_mmt branch June 26, 2024 10:53

tchaton added a commit that referenced this pull request Jun 26, 2024

Scale mmt (#19984)

c546dcb

tchaton mentioned this pull request Jun 26, 2024

Release 2.3.1 #20018

Closed

7 tasks

awaelchli pushed a commit that referenced this pull request Jun 27, 2024

Scale mmt (#19984)

a31d186

awaelchli added this to the 2.3.x milestone Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scale mmt #19984

Scale mmt #19984

tchaton commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading

Scale mmt #19984

Scale mmt #19984

Conversation

tchaton commented Jun 17, 2024 • edited Loading

What does this PR do?

PR review

github-actions bot commented Jun 17, 2024 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

tchaton commented Jun 17, 2024 •

edited

Loading

github-actions bot commented Jun 17, 2024 •

edited

Loading