Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback call in Fabric Trainer example #19986

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

liambsmith
Copy link
Contributor

@liambsmith liambsmith commented Jun 17, 2024

Fix for error:

TypeError: ModelHooks.on_before_optimizer_step() takes 2 positional arguments but 3 were given

The on_before_optimizer_step has no arguments, so the ", 0" part of the call caused this error.

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19986.org.readthedocs.build/en/19986/

Fix for error:

TypeError: ModelHooks.on_before_optimizer_step() takes 2 positional arguments but 3 were given

The on_before_optimizer_step has no arguments, so the ", 0" part of the call caused this error.
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 17, 2024
@awaelchli awaelchli changed the title Update trainer.py Fix callback call in Fabric Trainer example Jun 18, 2024
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liambsmith!

@awaelchli awaelchli added example bug Something isn't working labels Jun 18, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jun 18, 2024
@awaelchli awaelchli merged commit 394c42a into Lightning-AI:master Jun 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example fabric lightning.fabric.Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants