fix(wandb): use same logger on multiple training loops #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New training loops reset step to 0 which would previously try to overwrite logs fix Lightning-AI#2015
Codecov Report
@@ Coverage Diff @@
## master #2055 +/- ##
======================================
Coverage 86% 86%
======================================
Files 74 74
Lines 4710 4710
======================================
Hits 4066 4066
Misses 644 644 |
Borda
approved these changes
Jun 2, 2020
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* fix(wandb): use same logger on multiple training loops New training loops reset step to 0 which would previously try to overwrite logs fix #2015 * docs(changelog.md): add reference to PR 2055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #2015
New training loops reset step to 0 which would previously try to overwrite logs (not allowed by wandb).
Logs are now incremental and the step is logged as a separate metric, without modifying
metricsdictionary (which previously affected other loggers).PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭