Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: save hparams to yaml #2198

Merged
merged 5 commits into from
Jun 16, 2020
Merged

test: save hparams to yaml #2198

merged 5 commits into from
Jun 16, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 15, 2020

What does this PR do?

loading Attrib params from YAML

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration labels Jun 15, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 15, 2020
@Borda Borda requested review from awaelchli, williamFalcon and tullie and removed request for awaelchli and williamFalcon June 15, 2020 20:53
@mergify mergify bot requested a review from a team June 15, 2020 20:54
@Borda Borda added the priority: 0 High priority task label Jun 15, 2020
@Borda
Copy link
Member Author

Borda commented Jun 15, 2020

the cases are failing on minimal requirements... @omry any idea?

>       save_hparams_to_yaml(path_yaml, OmegaConf.create(hparams))

tests/models/test_hparams.py:428: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

data = {'batch_size': 32, 'data_root': './any/path/here', 'learning_rate': 0.001, 'nasted': {'any_num': 123, 'anystr': 'abcd'}}
stream = None, Dumper = <class 'yaml.dumper.Dumper'>
kwds = {'allow_unicode': True, 'default_flow_style': False, 'sort_keys': False}

    def dump(data, stream=None, Dumper=Dumper, **kwds):
        """
        Serialize a Python object into a YAML stream.
        If stream is None, return the produced string instead.
        """
>       return dump_all([data], stream, Dumper=Dumper, **kwds)
E       TypeError: dump_all() got an unexpected keyword argument 'sort_keys'

requirements/base.txt Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2020

This pull request is now in conflict... :(

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #2198 into master will increase coverage by 0%.
The diff coverage is 91%.

@@          Coverage Diff           @@
##           master   #2198   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          68      68           
  Lines        5249    5248    -1     
======================================
+ Hits         4600    4603    +3     
+ Misses        649     645    -4     

@williamFalcon williamFalcon merged commit e289e45 into master Jun 16, 2020
@Borda Borda deleted the tests/save-hparams branch June 16, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants