Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix progress bar loss value with gradient accumulation > 1 #2738

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix progress bar loss value with gradient accumulation > 1 #2738

merged 1 commit into from
Jul 28, 2020

Conversation

ibeltagy
Copy link
Contributor

@ibeltagy ibeltagy commented Jul 28, 2020 •
edited

What does this PR do?

Fixes #2635

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@ibeltagy ibeltagy changed the title fix https://github.com/PyTorchLightning/pytorch-lightning/issues/2635 fix progress bar loss value with gradient accumulation > 1 Jul 28, 2020
@mergify mergify bot requested a review from a team July 28, 2020 15:28
@Borda Borda added the bug Something isn't working label Jul 28, 2020
@williamFalcon williamFalcon merged commit c047676 into Lightning-AI:master Jul 28, 2020
@awaelchli awaelchli mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loss value in the progress bar is wrong when accumulate_grad_batches > 1
3 participants
@ibeltagy @williamFalcon @Borda