Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated in v0.9 #2760

Merged
merged 5 commits into from
Jul 30, 2020
Merged

remove deprecated in v0.9 #2760

merged 5 commits into from
Jul 30, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 30, 2020

What does this PR do?

remove deprecated API

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added ci Continuous Integration Important labels Jul 30, 2020
@mergify mergify bot requested a review from a team July 30, 2020 10:13
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #2760 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2760   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          82      76    -6     
  Lines        6826    6767   -59     
======================================
- Hits         6150    6107   -43     
+ Misses        676     660   -16     

@mergify mergify bot requested a review from a team July 30, 2020 17:44
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mergify mergify bot requested a review from a team July 30, 2020 18:09
@Borda Borda added the ready PRs ready to be merged label Jul 30, 2020
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 鉁岋笍

@Borda Borda merged commit 9497344 into master Jul 30, 2020
@Borda Borda deleted the deprecated/v0.9 branch July 30, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants