updated sync bn

[ananyahjha93]

What does this PR do?

Fixes # (issue)

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[nateraw]

Update trainer args so drone passes

[ananyahjha93]

@williamFalcon not sure why the drone test is failing, the same test passes locally and was passing in the previous commit

[williamFalcon]

we don’t need that anymore since u added the test using ddp spawn no?
we don’t need the example anymore

[ananyahjha93]

ddp_spawn test is called using the example, as a script test
@williamFalcon ^^^

[Borda]

we don’t need that anymore since u added the test using ddp spawn no?
we don’t need the example anymore

the test is the example, maybe we shall put it to test as some other people crossing over would raise the same question...

[pep8speaks]

Hello @ananyahjha93! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-05 22:55:59 UTC

[codecov]

Codecov Report

Merging #2838 into master will increase coverage by 4%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #2838    +/-   ##
=======================================
+ Coverage      86%     90%    +4%     
=======================================
  Files          78      78            
  Lines        7029    7029            
=======================================
+ Hits         6049    6338   +289     
+ Misses        980     691   -289     

[awaelchli]

nice addition @ananyahjha93 !

[awaelchli]

Just to double check, do we need TrialMNIST or MNIST?

[ananyahjha93]

I did not want to change TrialMNIST structure for this PR as I had to include a DistributedSampler with shuffle

[awaelchli]

I thought the Trainer / LightningModule will call these automatically? @nateraw