Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass non_blocking=True if it does not support this argument #2910

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Aug 11, 2020

What does this PR do?

Fixes #2637

The new test fails on master.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working docs Documentation related labels Aug 11, 2020
@awaelchli awaelchli changed the title Do not pass non_blocking=True if it does not support this argument [WIP] Do not pass non_blocking=True if it does not support this argument Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #2910 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2910   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          80      80           
  Lines        7422    7423    +1     
======================================
+ Hits         6706    6707    +1     
  Misses        716     716           

@awaelchli awaelchli marked this pull request as ready for review August 11, 2020 08:55
@mergify mergify bot requested a review from a team August 11, 2020 08:56
@awaelchli awaelchli changed the title [WIP] Do not pass non_blocking=True if it does not support this argument Do not pass non_blocking=True if it does not support this argument Aug 11, 2020
@Borda Borda added the ready PRs ready to be merged label Aug 11, 2020
@mergify mergify bot requested a review from a team August 11, 2020 23:11
@Borda Borda added this to the 0.9.0 milestone Aug 11, 2020
@williamFalcon williamFalcon merged commit 69d241c into master Aug 11, 2020
ameliatqy pushed a commit to ameliatqy/pytorch-lightning that referenced this pull request Aug 17, 2020
…ightning-AI#2910)

* add docs

* non blocking only on tensor

* changelog

* add test case

* add test comment

* update changelog


changelog


chlog
@Borda Borda deleted the bugfix/nonblocking branch August 20, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to() got an unexpected keyword argument 'non_blocking' for DGLGraph
3 participants