re-enabled naming metrics in ckpt name #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-20 00:34:09 UTC |
|
@williamFalcon fixes #3017 and not #3018 |
Codecov Report
@@ Coverage Diff @@
## master #3060 +/- ##
=======================================
+ Coverage 86% 90% +4%
=======================================
Files 81 81
Lines 7696 7700 +4
=======================================
+ Hits 6638 6950 +312
+ Misses 1058 750 -308 |
rohitgr7
reviewed
Aug 20, 2020
| @@ -75,6 +76,8 @@ def log_metrics(self, metrics, grad_norm_dic, step=None): | |||
| self.logger.agg_and_log_metrics(scalar_metrics, step=step) | |||
| self.logger.save() | |||
|
|
|||
| # track the logged metrics | |||
| self.logged_metrics = scalar_metrics | |||
There was a problem hiding this comment.
@williamFalcon naming metrics in ckpt filename is not possible if not using a logger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3017
Fixes #3000