Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable profilers to write to remote files with fsspec #4162

Merged
merged 7 commits into from Oct 25, 2020

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Oct 15, 2020

What does this PR do?

Similar to #3930

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@ananthsub ananthsub marked this pull request as draft October 15, 2020 03:39
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #4162 into master will increase coverage by 0%.
The diff coverage is 82%.

@@          Coverage Diff           @@
##           master   #4162   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         111     111           
  Lines        8068    8019   -49     
======================================
- Hits         7478    7454   -24     
+ Misses        590     565   -25     

@edenlightning edenlightning added this to the 1.0.3 milestone Oct 19, 2020
Enable profilers to use write to remote files with fsspec
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

pytorch_lightning/profiler/profilers.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 24, 2020 22:10
@awaelchli awaelchli added feature Is an improvement or enhancement ready PRs ready to be merged labels Oct 24, 2020
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@ananthsub ananthsub changed the title Enable profilers to use write to remote files with fsspec Enable profilers to write to remote files with fsspec Oct 25, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 25, 2020 10:12
@awaelchli awaelchli merged commit c8ccec7 into Lightning-AI:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants