Model summary: add 1 decimal place

[jonashaag]

What does this PR do?

Show 1999 parameters as 1.9 K and 1000 parameters as 1.0 K, rather than both as 1 K.

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

[edenlightning]

mind adding a test for this?

[jonashaag]

The docs are the tests :) but I can add more tests if the change is accepted.

[awaelchli]

@jonashaag the doctest is sufficient, you just need to fix the decimal point in the other places where the model summary string is tested.

[Borda]

it is a good point to show decimal when there is only 1 digit but later when you have thousands the meaning of decimal is meaningless >> 5,000.0

[jonashaag]

I can add a special case for T if you want

[Borda]

I can add a special case for T if you want

I would say whatever is above 100 does not need decimal and lower than 100 shows one decimal

[jonashaag]

OK, please review again.

[codecov]

Codecov Report

Merging #4745 (f620d6d) into master (b10b11d) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4745   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         117     117           
  Lines        8972    8974    +2     
======================================
+ Hits         8345    8347    +2     
  Misses        627     627           

[Borda]

nice, thx :]

[tchaton]

Great addition ! Would you mind adding a test ?

[jonashaag]

As said, the tests are in the docs (doctest) but if you want I can add separate unit tests.