Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5018

Merged
merged 8 commits into from
Dec 24, 2020
Merged

Update README.md #5018

merged 8 commits into from
Dec 24, 2020

Conversation

nightlessbaron
Copy link
Contributor

Corrects typo in ReadMe

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the docs Documentation related label Dec 8, 2020
@Borda Borda added this to the 1.1.x milestone Dec 8, 2020
@Borda Borda added the ready PRs ready to be merged label Dec 8, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #5018 (91a7a0b) into master (b930b5f) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5018   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9945    9933   -12     
======================================
- Hits         9259    9247   -12     
  Misses        686     686           

@Borda Borda requested a review from awaelchli December 10, 2020 08:25
@rohitgr7 rohitgr7 mentioned this pull request Dec 18, 2020
11 tasks
@awaelchli awaelchli enabled auto-merge (squash) December 23, 2020 18:28
@Borda
Copy link
Member

Borda commented Dec 24, 2020

@nightlessbaron mind resolve the conflict? 馃惏

@awaelchli awaelchli merged commit 90c1c0f into Lightning-AI:master Dec 24, 2020
Borda pushed a commit that referenced this pull request Jan 6, 2021
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Nicki Skafte <skaftenicki@gmail.com>
(cherry picked from commit 90c1c0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants