prune ecosystem example #5085
Merged
prune ecosystem example #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒 Comment last updated at 2020-12-17 08:25:12 UTC |
Closed
11 tasks
Borda
requested review from
awaelchli,
justusschock,
SeanNaren and
williamFalcon
as code owners
11 tasks
tchaton
approved these changes
Dec 11, 2020
|
|
||
| def nice_print(msg, last=False): | ||
| print() | ||
| print("\033[0;35m" + msg + "\033[0m") |
There was a problem hiding this comment.
We should try to find Pytorch Lightning color for terminal
justusschock
approved these changes
Dec 11, 2020
tchaton
approved these changes
Dec 14, 2020
awaelchli
approved these changes
Dec 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #5085 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9928 9928
======================================
Hits 9242 9242
Misses 686 686 |
awaelchli
pushed a commit
that referenced
this pull request
Dec 18, 2020
* draft * wip * CI * drop pl geometry * copy * logo
Borda
added a commit
that referenced
this pull request
Dec 23, 2020
* draft * wip * CI * drop pl geometry * copy * logo
Borda
added a commit
that referenced
this pull request
Dec 29, 2020
* draft * wip * CI * drop pl geometry * copy * logo
Borda
added a commit
that referenced
this pull request
Jan 4, 2021
* draft * wip * CI * drop pl geometry * copy * logo
Borda
added a commit
that referenced
this pull request
Jan 4, 2021
* draft * wip * CI * drop pl geometry * copy * logo
Borda
added a commit
that referenced
this pull request
Jan 5, 2021
* draft * wip * CI * drop pl geometry * copy * logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding dotest to examples ecosystem to make sure that they can instantiate... follow-up #5079
UPDATE: After talking with @tchaton we'll move this to the Geometry repo :]
added copyright and logos
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭