Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doc fixes #5139

Merged
merged 9 commits into from
Dec 24, 2020
Merged

Minor doc fixes #5139

merged 9 commits into from
Dec 24, 2020

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixed #4650, part of #5099, and some other doc fixes I found while reading.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@rohitgr7 rohitgr7 added the docs Documentation related label Dec 14, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 14, 2020
@rohitgr7 rohitgr7 marked this pull request as ready for review December 14, 2020 21:26
carmocca
carmocca reviewed Dec 15, 2020
View reviewed changes
docs/source/multi_gpu.rst Outdated Show resolved Hide resolved
@Borda @carmocca
Apply suggestions from code review
5b679fa 
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
Borda
Borda approved these changes Dec 16, 2020
View reviewed changes
docs/source/multi_gpu.rst Outdated Show resolved Hide resolved
docs/source/trainer.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 16, 2020 •
edited

Codecov Report

Merging #5139 (95d40f1) into master (90c1c0f) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5139   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9945    9945           
======================================
  Hits         9259    9259           
  Misses        686     686

awaelchli
awaelchli approved these changes Dec 16, 2020
View reviewed changes
docs/source/multi_gpu.rst Outdated Show resolved Hide resolved
docs/source/multi_gpu.rst Outdated Show resolved Hide resolved
docs/source/trainer.rst Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 changed the title Minor doc fixes Minor doc fixes [ci skip] Dec 16, 2020
@rohitgr7 rohitgr7 changed the title Minor doc fixes [ci skip] Minor doc fixes Dec 16, 2020
@Borda Borda added the ready PRs ready to be merged label Dec 17, 2020
@rohitgr7
Copy link
Contributor Author

@tchaton @williamFalcon mind review?

@Borda
Copy link
Member

Borda commented Dec 23, 2020

@tchaton mind review as code-owner? 馃惏

@Borda Borda enabled auto-merge (squash) December 23, 2020 16:20
@Borda Borda merged commit 8d8098c into master Dec 24, 2020
@Borda Borda deleted the docs/ddp_step_docs branch December 24, 2020 18:37
Borda pushed a commit that referenced this pull request Jan 6, 2021
@rohitgr7 @Borda
Minor doc fixes (#5139)
fe41492 
* minor doc fix

* minor doc fix

* Apply suggestions from code review

Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>

* suggestions

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
(cherry picked from commit 8d8098c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@s-rog s-rog s-rog approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1.x
Development

Successfully merging this pull request may close these issues.

Keep the setting of user created DataLoader in replacing DistributedSampler
7 participants
@rohitgr7 @Borda @awaelchli @carmocca @tchaton @ydcjeff @s-rog