Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make cmd - clean #5204

Merged
merged 2 commits into from
Dec 21, 2020
Merged

add make cmd - clean #5204

merged 2 commits into from
Dec 21, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 20, 2020

What does this PR do?

add cleaning command and drop the deprecated update.sh

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the refactor label Dec 20, 2020
@Borda Borda added this to the 1.1.x milestone Dec 20, 2020
@Borda Borda marked this pull request as ready for review December 20, 2020 11:18
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #5204 (74dd2c5) into master (c8eda3f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5204   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9933    9933           
======================================
  Hits         9247    9247           
  Misses        686     686           

@Borda Borda added the ready PRs ready to be merged label Dec 20, 2020
@rohitgr7 rohitgr7 merged commit 8ad7214 into master Dec 21, 2020
@rohitgr7 rohitgr7 deleted the refactor/make-clean branch December 21, 2020 06:35
Borda added a commit that referenced this pull request Dec 23, 2020
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Borda added a commit that referenced this pull request Dec 29, 2020
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Borda added a commit that referenced this pull request Jan 4, 2021
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Borda added a commit that referenced this pull request Jan 4, 2021
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Borda added a commit that referenced this pull request Jan 5, 2021
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants