black formatting and migrated to self.log logging in finetuning example #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspaezp
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5229 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9950 9950
======================================
Hits 9261 9261
Misses 689 689 |
awaelchli
approved these changes
Dec 22, 2020
awaelchli
added
example
bug
awaelchli
changed the title
rohitgr7
reviewed
Dec 22, 2020
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
migrated to accuracy in the metrics package
|
Hello @jspaezp! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-04 12:43:26 UTC |
rohitgr7
approved these changes
Dec 27, 2020
Borda
pushed a commit
that referenced
this pull request
Jan 6, 2021
…le (#5229) * black formatting and migrated to self.log logging * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * migrated to accuracy in the metrics package migrated to accuracy in the metrics package * removed trailing whitespace * Apply suggestions from code review Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Nicki Skafte <skaftenicki@gmail.com> (cherry picked from commit 17a0784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed in #5174, it fixes the computer_vision_fine_tuning example.
return {'log': ...}syntax instead of the currentself.log(...)syntax.I noticed the changes seem fairly large due to black changing some of the formatting (which is suggested in the contribution guidelines pre-commit). Let me know if you want these changes to be rolled back to preserve the 'blame' of the repository
Let me know if you would like anything to be changed.
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
I did have fun coding
Kindest wishes,
Sebastian