-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] [Docs] Add section about device placement #5280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
awaelchli,
Borda,
edenlightning and
tchaton
as code owners
December 27, 2020 19:57
Codecov Report
@@ Coverage Diff @@
## master #5280 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9950 9950
======================================
Hits 9261 9261
Misses 689 689 |
Shreeyak
reviewed
Dec 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful. Thanks for adding these details. I narrowly avoided using a native dict through luck.
Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com>
Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com>
Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com>
s-rog
approved these changes
Dec 28, 2020
Borda
approved these changes
Dec 28, 2020
awaelchli
approved these changes
Dec 28, 2020
rohitgr7
approved these changes
Dec 28, 2020
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
rohitgr7
reviewed
Dec 28, 2020
rohitgr7
reviewed
Dec 28, 2020
Borda
pushed a commit
that referenced
this pull request
Jan 6, 2021
* update docs * Update docs/source/metrics.rst Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com> * Update docs/source/metrics.rst Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com> * Update docs/source/metrics.rst Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com> * Update docs/source/metrics.rst * Update docs/source/metrics.rst * Update docs/source/metrics.rst * Apply suggestions from code review Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com> * Update docs/source/metrics.rst Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update docs/source/metrics.rst * Update docs/source/metrics.rst * try fix failing doc test Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: Shreeyak <shreeyak.sajjan@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> (cherry picked from commit dabfeca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4909
Adds a section to metrics docs about device placement
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭