-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Mention that datamodules can also be used with .test()
method
#5286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5286 +/- ##
======================================
- Coverage 93% 92% -1%
======================================
Files 134 134
Lines 9950 10030 +80
======================================
+ Hits 9261 9267 +6
- Misses 689 763 +74 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gotta address rohitgr7's comments!
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
What does this PR do?
Fixes #5265
Adds to docs that datamodules are also supported as a valid way to pass in an external dataloader
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭