Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Cast to string _flatten_dict #5354

Merged
merged 8 commits into from
Jan 5, 2021

Conversation

marload
Copy link
Contributor

@marload marload commented Jan 5, 2021

What does this PR do?

Fixes #5311 <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #5354 (ab5307b) into master (ec0fb7a) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5354   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9992    9993    +1     
======================================
+ Hits         9309    9310    +1     
  Misses        683     683           

@s-rog s-rog changed the title FIX-5311: Cast to string _fatten_dict FIX-5311: Cast to string _flatten_dict Jan 5, 2021
Copy link
Contributor

@s-rog s-rog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add more types to the test besides int since it's Any now?

@Borda Borda added this to the 1.1.x milestone Jan 5, 2021
@Borda Borda added the bug Something isn't working label Jan 5, 2021
@Borda Borda enabled auto-merge (squash) January 5, 2021 08:13
@Borda Borda changed the title FIX-5311: Cast to string _flatten_dict FIX Cast to string _flatten_dict Jan 5, 2021
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@awaelchli awaelchli added the ready PRs ready to be merged label Jan 5, 2021
@Borda Borda merged commit 6536ea4 into Lightning-AI:master Jan 5, 2021
@marload marload deleted the feature/5311-flatten-dict branch January 6, 2021 05:04
Borda pushed a commit that referenced this pull request Jan 6, 2021
* fix

* params

* add test

* add another types

* chlog

Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

(cherry picked from commit 6536ea4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-str key in hparam dict causes exception in logging
6 participants