Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update FairScale install instructions #5380

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jan 6, 2021

What does this PR do?

Fixes #5210 with latest fairscale release.

Upstream in FairScale we've added a unit test to make sure this is covered, so it might be alright for now to keep the version the same here for our unit testing. Can address in a separate PR if needed in the future.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added docs Documentation related distributed Generic distributed-related topic labels Jan 6, 2021
@SeanNaren SeanNaren added this to the 1.1.x milestone Jan 6, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it might be alright for now to keep the version the same here for our unit testing

I agree with keeping that test upstream

@SkafteNicki SkafteNicki enabled auto-merge (squash) January 6, 2021 12:11
@@ -654,7 +654,7 @@ To use Sharded Training, you need to first install FairScale using the command b

.. code-block:: bash

pip install https://github.com/PyTorchLightning/fairscale/archive/pl_1.1.0.zip
pip install fairscale
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update it also in requirements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a note of it in the main post. We can but it isn't necessary, the unit test for the additional fixes is in Fairscale. Till, pipe RPC becomes a bit more stable let's keep this pointed to our own fork!

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #5380 (10fbc6b) into master (019e4ff) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5380   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9994    9994           
======================================
- Hits         9310    9309    -1     
- Misses        684     685    +1     

@Borda Borda added the ready PRs ready to be merged label Jan 6, 2021
@SkafteNicki SkafteNicki merged commit ee83731 into master Jan 6, 2021
@SkafteNicki SkafteNicki deleted the doc/sharded_install branch January 6, 2021 15:02
SeanNaren added a commit that referenced this pull request Jan 12, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
SeanNaren added a commit that referenced this pull request Jan 12, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
SeanNaren added a commit that referenced this pull request Jan 13, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
SeanNaren added a commit that referenced this pull request Jan 13, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
asnorkin pushed a commit to asnorkin/pytorch-lightning that referenced this pull request Jan 15, 2021
SeanNaren added a commit that referenced this pull request Jan 19, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Borda pushed a commit that referenced this pull request Jan 23, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Borda pushed a commit that referenced this pull request Jan 25, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Borda pushed a commit that referenced this pull request Jan 26, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Borda pushed a commit that referenced this pull request Jan 26, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Borda pushed a commit that referenced this pull request Jan 26, 2021
… fork required for sequential parallelism (#5380)

(cherry picked from commit ee83731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use SyncBN with sharded DDP.
6 participants