-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update FairScale install instructions #5380
Conversation
… fork required for sequential parallelism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it might be alright for now to keep the version the same here for our unit testing
I agree with keeping that test upstream
@@ -654,7 +654,7 @@ To use Sharded Training, you need to first install FairScale using the command b | |||
|
|||
.. code-block:: bash | |||
|
|||
pip install https://github.com/PyTorchLightning/fairscale/archive/pl_1.1.0.zip | |||
pip install fairscale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we update it also in requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a note of it in the main post. We can but it isn't necessary, the unit test for the additional fixes is in Fairscale. Till, pipe RPC becomes a bit more stable let's keep this pointed to our own fork!
Codecov Report
@@ Coverage Diff @@
## master #5380 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 134 134
Lines 9994 9994
======================================
- Hits 9310 9309 -1
- Misses 684 685 +1 |
… fork required for sequential parallelism (Lightning-AI#5380)
What does this PR do?
Fixes #5210 with latest fairscale release.
Upstream in FairScale we've added a unit test to make sure this is covered, so it might be alright for now to keep the version the same here for our unit testing. Can address in a separate PR if needed in the future.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃