Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generate checkpoint #5489

Merged
merged 1 commit into from
Jan 12, 2021
Merged

fix generate checkpoint #5489

merged 1 commit into from
Jan 12, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 12, 2021

What does this PR do?

the installation fails for the presence of multiple packages of the same version as we generate the for upload to PyPI
it is p1 till need it for release but we have a week, then it becomes p0
see: https://github.com/PyTorchLightning/pytorch-lightning/runs/1690836716?check_suite_focus=true#step:15:39

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added ci Continuous Integration priority: 1 Medium priority task labels Jan 12, 2021
@Borda Borda added this to the 1.1.x milestone Jan 12, 2021
@Borda Borda requested a review from tchaton as a code owner January 12, 2021 21:01
@SeanNaren SeanNaren added the ready PRs ready to be merged label Jan 12, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) January 12, 2021 21:25
@SeanNaren SeanNaren merged commit 1f6236a into master Jan 12, 2021
@SeanNaren SeanNaren deleted the ci/fix-ckpt branch January 12, 2021 21:35
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #5489 (347aa94) into master (652df18) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5489   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10015   10015           
======================================
  Hits         9338    9338           
  Misses        677     677           

@Borda Borda self-assigned this Jan 14, 2021
Borda added a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants