Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pipeline release CI #5494

Merged
merged 11 commits into from
Jan 13, 2021
Merged

fix: pipeline release CI #5494

merged 11 commits into from
Jan 13, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 13, 2021

What does this PR do?

separate if some particular phase of three fails
it also adds creating ckpt if it was missing

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the ci Continuous Integration label Jan 13, 2021
@Borda Borda added this to the 1.1.x milestone Jan 13, 2021
@Borda
Copy link
Member Author

Borda commented Jan 13, 2021

Screenshot 2021-01-13 at 11 01 10

@Borda Borda marked this pull request as ready for review January 13, 2021 10:02
@Borda Borda requested a review from tchaton as a code owner January 13, 2021 10:02
@Borda Borda enabled auto-merge (squash) January 13, 2021 10:02
@Borda Borda marked this pull request as draft January 13, 2021 11:04
auto-merge was automatically disabled January 13, 2021 11:04

Pull request was converted to draft

@Borda Borda marked this pull request as ready for review January 13, 2021 11:21
@Borda Borda enabled auto-merge (squash) January 13, 2021 11:21
@Borda Borda added the ready PRs ready to be merged label Jan 13, 2021
@Borda Borda self-assigned this Jan 13, 2021
@Borda Borda changed the title pipeline release CI fix: pipeline release CI Jan 13, 2021
@Borda Borda mentioned this pull request Jan 13, 2021
12 tasks
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
@Borda Borda requested a review from carmocca January 13, 2021 15:39
@Borda Borda merged commit 83b1ff4 into master Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5494 (48e8474) into master (4c78804) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5494   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10015   10015           
======================================
  Hits         9338    9338           
  Misses        677     677           

@Borda Borda deleted the ci/release branch January 13, 2021 19:02
Borda added a commit that referenced this pull request Feb 4, 2021
* pipeline release CI

* trigger

* trigger

* .

* t1

* t2

* t1

* t2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants