Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconfigure mergify #5499

Merged
merged 7 commits into from
Jan 14, 2021
Merged

reconfigure mergify #5499

merged 7 commits into from
Jan 14, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 13, 2021

What does this PR do?

Resowing following problems:

Some concerns:

  • the only question is how the update works here if it requires also resolve conflicts, which is not well described in docs

discussed with @SeanNaren

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added the ci Continuous Integration label Jan 13, 2021
@Borda Borda self-assigned this Jan 13, 2021
@Borda
Copy link
Member Author

Borda commented Jan 13, 2021

yeah, I have resolved conflicts so atm the label shall be removed, hut it is till there... :/

@Borda Borda added this to the 1.1.x milestone Jan 13, 2021
@Borda Borda marked this pull request as ready for review January 13, 2021 14:57
@Borda Borda requested a review from tchaton as a code owner January 13, 2021 14:57
.mergify.yml Outdated Show resolved Hide resolved
@Borda Borda added the ready PRs ready to be merged label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5499 (6a9c620) into master (71d5cc1) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5499    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10006    9866   -140     
=======================================
- Hits         9329    9176   -153     
- Misses        677     690    +13     

@Borda Borda enabled auto-merge (squash) January 13, 2021 22:30
@Borda Borda disabled auto-merge January 14, 2021 15:53
@Borda Borda merged commit 24fb75a into master Jan 14, 2021
@Borda Borda deleted the ci/mergify branch January 14, 2021 15:53
Borda added a commit that referenced this pull request Feb 4, 2021
* configure mergify

* drop gha

* drop commented section

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration has conflicts ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants