-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconfigure mergify #5499
Merged
Merged
reconfigure mergify #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeah, I have resolved conflicts so atm the label shall be removed, hut it is till there... :/ |
Borda
requested review from
carmocca,
nateraw,
s-rog,
SeanNaren and
teddykoker
January 13, 2021 14:58
carmocca
reviewed
Jan 13, 2021
carmocca
approved these changes
Jan 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #5499 +/- ##
=======================================
- Coverage 93% 93% -0%
=======================================
Files 135 135
Lines 10006 9866 -140
=======================================
- Hits 9329 9176 -153
- Misses 677 690 +13 |
rohitgr7
approved these changes
Jan 13, 2021
s-rog
approved these changes
Jan 14, 2021
tchaton
approved these changes
Jan 14, 2021
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* configure mergify * drop gha * drop commented section Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resowing following problems:
Some concerns:
discussed with @SeanNaren
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭